I have found at least 3 errors in the documentation for the Simulink generic battery model. https://www.mathworks.com/help/physmod/sps/powersys/ref/battery.html
1) In the diagram, f1 and f2 are shown as the functions describing charge and discharge, but in the text it is the reverse
2) The parameter "K" is shown as having units of 1/Ah. This is incorrect. The original paper (https://pdfs.semanticscholar.org/8f16/68ffef08c83a3a69f8f3c557d04cd9a5ffc2.pdf) gives its units as V/Ah.
3) Most importantly, functions f1 and f2 depend on "it" and "i*", which have dimensions of Ah and A, respectively. However, these 2 variables are treated on the same footing in the equations for f1 and f2, so that the dimensions of their respective terms are not consistent. If this is true in the code as well then the model is incorrect. This error is present in the original paper as well. This paper (https://www.nrel.gov/docs/fy17osti/67809.pdf) references the original paper, and replaces "it" with "i(t)" to get the dimensions consistent. However, they also keep the units of "K" as V/Ah. which would give the "i(t)" and "i*" terms units of V/h, which can't be correct.
I would like to report this problem to Mathworks, but when I click on the "report a bug" link (https://www.mathworks.com/support/servicerequests/create.html?s_tid=bug2create) I get redirected to login to "salesforce." I don't have a salesforce account, nor do I want one. Anyone know how to report problems to Mathworks?